Second round of changes #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the updates @ttjoseph . However, it's difficult for me to review anything here because it's a PR to a forked repo. @jhenin or someone else with write access should have a look. Once these changes appear in PR alchemistry#135 in the alchemlyb repo I will re-review when I cab see the test and coverage changes. |
|
Thank you @ttjoseph ! I just rebased master onto the base repo. This PS has merge conflicts apparently, can you check that? |
|
@jhenin I may have fixed this. I created a new branch for these fixes and will make a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @orbeckst. As of now, still need to add more test(s).