-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to do a real login for OAuth #660
Conversation
Unfortunately, this won't work with Keycloak at a domain different then localhost. |
You're right. If I try to do this:
I get the following error when running Cypress tests. This kinda stinks because it means you can't run Cypress tests when running the backend via Docker Compose. That's the only downside I see. You shouldn't be using Keycloak in production anyway. ;) |
What do you think about using the API method for Keycloak and using origin for Auth0 and Okta? |
Sure, we can move keycloak ui once cypress fixes it. |
OK, this PR now uses the API for Keycloak. I tested it on Keycloak with the default settings, as well as:
I tested it on Okta and Auth0 too. There is a test in // Incompatible with oauth login by api
it('should login successfully with admin account', () => {
cy.login(ADMIN_USERNAME, ADMIN_PASSWORD);
cy.visit('/');
const welcome = /Welcome, Admin/;
cy.get('app-home ion-title').invoke('text').should('match', welcome);
}); |
Fixes #656.