-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to generator-jhipster v8 #926
Conversation
@mshima I tried again and made it to the tutorial's I also noticed that uploading a new image through the web UI used to work. Now it says "Camera plugin not supported" in the console. In the last version, there was an else clause that made it so the web UI worked too. |
Try Edit:
|
Why is this necessary for this blueprint but not for the main generator?
This fails, too:
|
It’s using 127.0.0.1 jhipster/generator-jhipster@2048035
It’s probably a warning. |
The main generator uses very few access from outside the container limited to npm scripts. |
I tried changing
However, the tests still use "e2e": {
"builder": "@cypress/schematic:cypress",
"options": {
"devServerTarget": "app:serve",
"watch": false,
"headed": true,
"browser": "chrome",
"baseUrl": "http://127.0.0.1:8100/"
}, This makes it so 127.0.0.1 is used, but the tests still fail to resolve the website. I can click on the website when the tests are running, and it loads. |
For some reason, |
If I run |
@mraible cypress should be fixed with camera capacitor. |
I've tested using the following jdl:
Start backend with ionic cors:
In another terminal run e2e:
|
I didn't had to use 127.0.0.1 or NODE_OPTIONS for this test. |
@mshima I think this change is necessary to fix image upload when going through a browser. |
Why? It's working for me when I click at album button. |
It's possible to force the file dialog by setting |
@mshima What OS are you on? On my MacBook Pro M1 with macOS Ventura 13.6, I only see an error in the console:
|
MacBook Air M1 with macOS 13.4 |
@mshima This doesn't work for me. I tried in Chrome, Firefox, and Safari and the results are the same. Here's a video. photo-upload.mp4It's possible Okta is preventing this on my machine. However, I have no other machine to test it on. Regarding
|
* Fix image upload for web UI * Fix template * Apply suggestions from code review * fix references * add useCameraCapacitor * use input conditional on !useCameraCapacitor * Update generators/ionic/templates/src/app/pages/entities/_entity-update.ts.ejs * Update generators/ionic/templates/src/app/pages/entities/_entity-update.ts.ejs * Update _entity-update.ts.ejs * Update generators/ionic/templates/src/app/pages/entities/_entity-update.ts.ejs --------- Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@mshima I can confirm that this branch fixes image upload on the web. I still can't run FWIW, it works if I run |
e2e is not prepared for the fallback. |
Fixes #927