Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing deprecated methods and simplifying code #305

Closed
wants to merge 12 commits into from

Conversation

amatosg
Copy link

@amatosg amatosg commented Nov 15, 2023

  • ProfileManager.getActiveProfile() has been deprecated in favor of ConfigUtils.getProfiles()
  • Code improvement

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mraible
Copy link
Contributor

mraible commented Feb 25, 2024

@amatosg Can you please merge the main branch with yours to see if more CI tests pass?

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mraible
Copy link
Contributor

mraible commented Feb 26, 2024

@amatosg I was able to merge the main branch. Now tests are failing. Please review when you get a chance.

@amatosg
Copy link
Author

amatosg commented Feb 26, 2024 via email

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

Copy link

Copy link

@mraible
Copy link
Contributor

mraible commented Oct 31, 2024

@amatosg Are you still working on this?

@mraible
Copy link
Contributor

mraible commented Dec 26, 2024

Closing this PR since tests are failing. Please reopen if you'd still like to see improvement.

@mraible mraible closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants