Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yeoman-generator to v7 #23868

Closed
1 task
mshima opened this issue Oct 16, 2023 · 0 comments · Fixed by #24020
Closed
1 task

Update yeoman-generator to v7 #23868

mshima opened this issue Oct 16, 2023 · 0 comments · Fixed by #24020

Comments

@mshima
Copy link
Member

mshima commented Oct 16, 2023

Overview of the feature request

mem-fs@4.0.0 introduced a pipeline operation.
mem-fs-editor@11, yeoman-environment@4.0.0-rc.0 and yeoman-generator@7.0.0-rc.0 was adjusted to support and only supports mem-fs@4.

mem-fs@4 and yeoman-environment@4.0.0-rc.0 should be available since #23867.

Changes:

  • bump mem-fs-editor to v11.
  • bump yeoman-generator to v7.
  • adjust queueTransformStream and commit apis usage.
  • rework multiStepTransform, rework packageInfoTransform, rework TranslationData transform.
  • minor adjusts to others transforms may be required we have ~12 others transforms.

Those changes are required to fix #23391.

Those changes need to be simultaneous.

Motivation for or Use Case

Those updated apis provides a much better in pipeline transform support by allowing file creation and file deleting inside the pipeline.

Remove workarounds:

  • Testing multistep files requires .jhi extension:
it('should generate entities containing jakarta', () => {
  result.assertFileContent('src/main/java/com/mycompany/myapp/domain/Foo.java.jhi', 'jakarta');
});
  • edit falls back to .jhi extension:

    if (!this.env.sharedFs.existsInMemory(filePath) && this.env.sharedFs.existsInMemory(`${filePath}.jhi`)) {

  • If a blueprint writes the non .jhi file, a conflict is created due to write/override the same file.
    They are actually different files for mem-fs.

Related issues or PR

#23391

  • Checking this box is mandatory (this is just to show you read everything)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants