Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Maven and Gradle Deployment Commands in GAE Subgenerator #11036

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Simplify Maven and Gradle Deployment Commands in GAE Subgenerator #11036

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
effa44b
simplify maven and gradle deployment commands to GAE
SudharakaP Dec 26, 2019
a9dca7d
fix linting issues
SudharakaP Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions generators/gae/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,16 +773,10 @@ module.exports = class extends BaseGenerator {

if (this.buildTool === 'maven') {
this.log(chalk.bold('\nRun App Engine DevServer Locally: ./mvnw package appengine:run -DskipTests'));
this.log(
chalk.bold('Deploy to App Engine: ./mvnw clean && ./mvnw package appengine:deploy -DskipTests -Pgae,prod-gae')
);
this.log(chalk.bold('Deploy to App Engine: ./mvnw package appengine:deploy -DskipTests -Pgae,prod-gae'));
} else if (this.buildTool === 'gradle') {
this.log(chalk.bold('\nRun App Engine DevServer Locally: ./gradlew appengineRun'));
this.log(
chalk.bold(
'Deploy to App Engine: ./gradlew thinResolve -Pgae -Pprod-gae && ./gradlew appengineDeploy -Pgae -Pprod-gae'
)
);
this.log(chalk.bold('Deploy to App Engine: ./gradlew appengineDeploy -Pgae -Pprod-gae'));
}
/*
if (this.gcpSkipBuild || this.gcpDeployType === 'git') {
Expand Down