-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: improve triage #12641
GitHub Actions: improve triage #12641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. I was thinking about this a while ago. 😄
@SudharakaP : it seems broken. See https://github.com/jhipster/generator-jhipster/runs/1319668840 :( |
…labels are added This adds support to the triage action to gracefully handle the case where both area and theme labels are already added. Related to jhipster#12641
@pascalgrimaud : I think this is due to the fact that we are trying to pass en empty array when both Reference: https://docs.github.com/en/free-pro-team@latest/rest/reference/issues#add-labels-to-an-issue |
thanks for the fix @SudharakaP |
You are welcome. 👍🏽 |
…labels are added This adds support to the triage action to gracefully handle the case where both area and theme labels are already added. Related to jhipster#12641
Before applying these labels:
area: triage
andtheme: undefined
, it will check if onearea
ortheme
already exists.It will help the core developers to create a new tickets with appropriate labels, without waiting for removing
area: triage
andtheme: undefined
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.