Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: improve triage #12641

Merged

Conversation

pascalgrimaud
Copy link
Member

@pascalgrimaud pascalgrimaud commented Oct 4, 2020

Before applying these labels: area: triage and theme: undefined, it will check if one area or theme already exists.
It will help the core developers to create a new tickets with appropriate labels, without waiting for removing area: triage and theme: undefined


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@SudharakaP SudharakaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I was thinking about this a while ago. 😄

.github/workflows/triage.yml Outdated Show resolved Hide resolved
@SudharakaP SudharakaP merged commit 08aae8c into jhipster:master Oct 4, 2020
@pascalgrimaud pascalgrimaud added this to the 7.0.0 milestone Oct 18, 2020
@pascalgrimaud
Copy link
Member Author

@SudharakaP : it seems broken. See https://github.com/jhipster/generator-jhipster/runs/1319668840 :(
If you understand the error ...

SudharakaP added a commit to SudharakaP/generator-jhipster that referenced this pull request Oct 28, 2020
…labels are added

This adds support to the triage action to gracefully handle the case where both area and theme labels are already added.

Related to jhipster#12641
@SudharakaP
Copy link
Member

@SudharakaP : it seems broken. See https://github.com/jhipster/generator-jhipster/runs/1319668840 :(
If you understand the error ...

@pascalgrimaud : I think this is due to the fact that we are trying to pass en empty array when both area: and theme: labels are already there. So we have to check first. I've just opened a PR with the fix. 😄

Reference: https://docs.github.com/en/free-pro-team@latest/rest/reference/issues#add-labels-to-an-issue

@pascalgrimaud
Copy link
Member Author

thanks for the fix @SudharakaP

@SudharakaP
Copy link
Member

thanks for the fix @SudharakaP

You are welcome. 👍🏽

Tcharl pushed a commit to Tcharl/generator-jhipster that referenced this pull request Nov 7, 2020
…labels are added

This adds support to the triage action to gracefully handle the case where both area and theme labels are already added.

Related to jhipster#12641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants