Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable mariadb/mysql webflux tests #20351

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Nov 17, 2022

MariaDB driver is not compatible with current r2dbc version.

Reference spring-projects/spring-data-relational#1364 (comment)


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima requested a review from mraible November 17, 2022 15:01
@mraible
Copy link
Contributor

mraible commented Nov 17, 2022

If MariaDB doesn't work with Spring WebFlux, we should disable it as an option in JDL, the CLI, and JHipster Online too.

@mshima
Copy link
Member Author

mshima commented Nov 17, 2022

We can wait to see how spring boot 3 progresses.
Maybe support is added before final v8

@mraible
Copy link
Contributor

mraible commented Nov 17, 2022

Sounds good. Can you please enter an issue to track so we don't ship with MariaDB enabled if it doesn't work?

@mshima
Copy link
Member Author

mshima commented Nov 17, 2022

Done #20363.

@mshima mshima merged commit 915e10d into jhipster:spring-boot-3.0-m4 Nov 17, 2022
@mshima mshima deleted the skip_ci-mariadb branch November 17, 2022 16:32
mshima added a commit that referenced this pull request Dec 8, 2022
mshima added a commit that referenced this pull request Mar 22, 2023
mshima added a commit to mshima/generator-jhipster that referenced this pull request Apr 5, 2023
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants