fix: migrate to new kafka spring cloud stream #20433

codedsun · 2022-11-22T18:08:21Z

fix: #20297 migrate to new kafka spring cloud stream

Please make sure the below checklist is followed for Pull Requests.

All continuous integration tests are green
Tests are added where necessary
The JDL part is updated if necessary
jhipster-online is updated if necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

codedsun · 2022-11-23T10:31:48Z

@mshima - how do i test this failing changes on my local.? Also when I am this branch - i cant run jhipster

mshima · 2022-11-23T13:42:48Z

@codedsun you need to remove the files from

generator-jhipster/generators/kafka/files.mjs

Lines 29 to 34 in e17f956

    
             { 
        
               path: `${SERVER_MAIN_SRC_DIR}package/`, 
        
               renameTo: moveToJavaPackageSrcDir, 
        
               templates: ['config/KafkaSseConsumer.java', 'config/KafkaSseProducer.java'], 
        
             }, 
        
           ],

generators/server/templates/src/main/java/package/config/WebConfigurer.java.ejs

generators/kafka/templates/src/main/java/package/web/rest/KafkaResource.java.ejs

codedsun · 2022-11-23T14:44:54Z

Done @mshima .

codedsun · 2022-11-23T15:28:23Z

@mshima dont know why these workflows are failing, but what steps u mentioned in the sample project were working fine. Can you help me next what should I do?

generators/kafka/templates/src/main/java/package/web/rest/KafkaConfiguration.java.ejs

generators/kafka/files.mjs

generators/server/templates/src/main/java/package/config/WebConfigurer.java.ejs

generators/kafka/templates/src/main/java/package/config/KafkaSseConsumer.java.ejs

codedsun · 2022-11-28T10:27:47Z

@mshima Thanks, I will push my changes by thursday.

codedsun · 2022-12-01T17:27:00Z

@mshima done the changes, please check the jhipster version is correct or not in cleanup.mjs

mshima

You need to run

UPDATE_SNAPSHOT=all npx mocha generators/kafka

CI is failling:

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project sample-mongo-kafka: Compilation failure: Compilation failure: 
[851](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:852)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[18,46] cannot find symbol
[852](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:853)
Error:    symbol:   variable MimeTypeUtils
[853](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:854)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[854](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:855)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[28,13] cannot find symbol
[855](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:856)
Error:    symbol:   variable log
[856](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:857)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[857](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:858)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[29,13] cannot find symbol
[858](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:859)
Error:    symbol:   variable emitters
[859](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:860)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[860](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:861)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[33,27] cannot find symbol
[861](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:862)
Error:    symbol:   class SseEmitter
[862](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:863)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[863](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:864)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[35,73] cannot find symbol
[864](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:865)
Error:    symbol:   variable MediaType
[865](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:866)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[866](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:867)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[35,38] cannot find symbol
[867](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:868)
Error:    symbol:   method event()
[868](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:869)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[869](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:870)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[36,30] cannot find symbol
[870](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:871)
Error:    symbol:   class IOException
[871](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:872)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[872](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:873)
Error:  /home/runner/work/generator-jhipster/generator-jhipster/app/src/main/java/tech/jhipster/sample/config/KafkaConfiguration.java:[37,25] cannot find symbol
[873](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:874)
Error:    symbol:   variable log
[874](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:875)
Error:    location: class tech.jhipster.sample.config.KafkaConfiguration
[875](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:876)
Error:  -> [Help 1]
[876](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:877)
Error:  
[877](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:878)
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
[878](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:879)
Error:  Re-run Maven using the -X switch to enable full debug logging.
[879](https://github.com/jhipster/generator-jhipster/actions/runs/3597751065/jobs/6059838044#step:20:880)
Error:

mshima · 2022-12-02T00:28:57Z

generators/kafka/cleanup.mjs

@@ -40,4 +40,8 @@ export default function cleanupKafkaFilesTask({ application }) {
  if (this.isJhipsterVersionLessThan('7.7.1')) {
    this.removeFile(`${application.javaPackageSrcDir}config/KafkaProperties.java`);
  }
+  if (this.isJhipsterVersionLessThan('7.9.3')) {


Suggested change

if (this.isJhipsterVersionLessThan('7.9.3')) {

if (this.isJhipsterVersionLessThan('7.10.0')) {

codedsun · 2022-12-02T17:44:15Z

@mshima done the changes.

codedsun · 2022-12-03T11:44:15Z

@mshima - i see some test are not able to found the files, though they were working fine for my created project and the steps u provided to test. Can you help me for the CI build to pass?

codedsun · 2022-12-03T17:32:17Z

@mshima please run the tests..after ur changes 1 test was failing I fixed that. Thanks

codedsun · 2022-12-04T16:33:59Z

Hey @mshima , am I doing something wrong in code? Please guide me from here.

mshima · 2022-12-04T18:35:42Z

Is missing a conversation somewhere.

expected: "value-produce"
[1541](https://github.com/jhipster/generator-jhipster/actions/runs/3614071130/jobs/6090381311#step:20:1542)
 but was: [118, 97, 108, 117, 101, 45, 112, 114, 111, 100, 117, 99, 101]

The got value is the char[] value of the expected

mshima · 2022-12-10T14:02:50Z

@codedsun please reopen the PR against main.

codedsun · 2022-12-12T16:41:24Z

@mshima this was closed, i though this got resolved by someone else, can i still work ?

mshima · 2022-12-12T17:12:44Z

@codedsun was closed because the target branch was merged to main.
Not sure why the target branch wasn't updated, I wasn't able to change manually either.
Go ahead and recreate the PR against main.

DanielFran · 2022-12-21T19:34:22Z

@codedsun Can you create a new PR based on main branch?

github-actions bot added the theme: java label Nov 22, 2022

codedsun mentioned this pull request Nov 22, 2022

Migrate to new Kafka Spring Cloud Stream support #20297

Closed

codedsun force-pushed the suneet/kafka_fix branch 3 times, most recently from b5e8a5f to 0da96ec Compare November 23, 2022 10:28

mshima reviewed Nov 23, 2022

View reviewed changes

generators/server/templates/src/main/java/package/config/WebConfigurer.java.ejs Outdated Show resolved Hide resolved

mshima reviewed Nov 23, 2022

View reviewed changes

generators/kafka/templates/src/main/java/package/web/rest/KafkaResource.java.ejs Outdated Show resolved Hide resolved

codedsun force-pushed the suneet/kafka_fix branch 2 times, most recently from 462b697 to 3aa1351 Compare November 23, 2022 14:30

mshima reviewed Nov 23, 2022

View reviewed changes

fix: migrate to new kafka spring cloud stream

9391ab3

codedsun force-pushed the suneet/kafka_fix branch from 3aa1351 to 9391ab3 Compare December 1, 2022 17:23

mshima added 2 commits December 1, 2022 18:36

move KafkaConfiguration to package/config

db23026

Fix KafkaConfiguration.java imports

b887224

mshima reviewed Dec 2, 2022

View reviewed changes

codedsun added 2 commits December 2, 2022 23:12

fix: Version for jHipster in cleanup.mjs

f24f994

fix: snapshots for kafka

fe4c9a8

codedsun force-pushed the suneet/kafka_fix branch from 4a1770d to 6c26640 Compare December 3, 2022 08:41

codedsun requested a review from mshima December 3, 2022 09:34

codedsun force-pushed the suneet/kafka_fix branch from 6c26640 to 6f120da Compare December 3, 2022 10:10

fix: Imports for configuration

c92b133

codedsun force-pushed the suneet/kafka_fix branch from 6f120da to c92b133 Compare December 3, 2022 11:08

mshima and others added 2 commits December 3, 2022 14:17

add spring-cloud-stream-test-binder dependency

9455a5e

fix: Added outputdestination in test

6235eb9

fix: Test failing for angular jobs related to kafka

8f5738b

DanielFran deleted the branch jhipster:spring-boot-3.0-m4 December 9, 2022 20:50

DanielFran closed this Dec 9, 2022

mshima mentioned this pull request Dec 13, 2022

disable kafka tests. #20597

Merged

6 tasks

DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: migrate to new kafka spring cloud stream #20433

fix: migrate to new kafka spring cloud stream #20433

codedsun commented Nov 22, 2022 •

edited

Loading

codedsun commented Nov 23, 2022 •

edited

Loading

mshima commented Nov 23, 2022

codedsun commented Nov 23, 2022

codedsun commented Nov 23, 2022

codedsun commented Nov 28, 2022 •

edited

Loading

codedsun commented Dec 1, 2022

mshima left a comment

mshima Dec 2, 2022

codedsun commented Dec 2, 2022

codedsun commented Dec 3, 2022

codedsun commented Dec 3, 2022

codedsun commented Dec 4, 2022 •

edited

Loading

mshima commented Dec 4, 2022

mshima commented Dec 10, 2022

codedsun commented Dec 12, 2022

mshima commented Dec 12, 2022

DanielFran commented Dec 21, 2022

	if (this.isJhipsterVersionLessThan('7.9.3')) {
	if (this.isJhipsterVersionLessThan('7.10.0')) {

fix: migrate to new kafka spring cloud stream #20433

fix: migrate to new kafka spring cloud stream #20433

Conversation

codedsun commented Nov 22, 2022 • edited Loading

fix: #20297 migrate to new kafka spring cloud stream

codedsun commented Nov 23, 2022 • edited Loading

mshima commented Nov 23, 2022

codedsun commented Nov 23, 2022

codedsun commented Nov 23, 2022

codedsun commented Nov 28, 2022 • edited Loading

codedsun commented Dec 1, 2022

mshima left a comment

Choose a reason for hiding this comment

mshima Dec 2, 2022

Choose a reason for hiding this comment

codedsun commented Dec 2, 2022

codedsun commented Dec 3, 2022

codedsun commented Dec 3, 2022

codedsun commented Dec 4, 2022 • edited Loading

mshima commented Dec 4, 2022

mshima commented Dec 10, 2022

codedsun commented Dec 12, 2022

mshima commented Dec 12, 2022

DanielFran commented Dec 21, 2022

codedsun commented Nov 22, 2022 •

edited

Loading

codedsun commented Nov 23, 2022 •

edited

Loading

codedsun commented Nov 28, 2022 •

edited

Loading

codedsun commented Dec 4, 2022 •

edited

Loading