Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default serverPort when there's no applicationIndex #20838

Closed
wants to merge 4 commits into from

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Jan 16, 2023

fixes #19782


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

generators/server/generator.mjs Outdated Show resolved Hide resolved
Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
@Tcharl
Copy link
Contributor Author

Tcharl commented Jan 16, 2023

Oups, sorry @DanielFran , it was a code point

@mshima
Copy link
Member

mshima commented Jan 17, 2023

It workaround the initial generation, but others configs and generators may still be broken, see #20839

@Tcharl
Copy link
Contributor Author

Tcharl commented Jan 17, 2023

Both PRs are complementary and valid to my understanding.
The issue which is fixed by this one is an empty port entry in a spring configuration which makes configuration validation to fail: http://localhost:.

Ok, I see what you mean. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Spring Boot 3
3 participants