Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix react admin menu using module federation. #22264

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented May 23, 2023

Fixes #21990


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima requested a review from mraible May 23, 2023 20:03
@mraible
Copy link
Contributor

mraible commented May 23, 2023

I tried re-creating everything using this branch, and the error still happens.

Screenshot 2023-05-23 at 2 28 30 PM

@mshima
Copy link
Member Author

mshima commented May 23, 2023

Indeed, I fixed locally with others modifications that cannot be applied.
This only fixes a warning.

@github-actions github-actions bot added the theme: dependencies Pull requests that update a dependency file label May 23, 2023
@mshima mshima marked this pull request as draft May 23, 2023 22:00
@mshima
Copy link
Member Author

mshima commented May 24, 2023

Using dynamic module federation load is the only way I found to fix the problem.
It makes the experience better.
But @angular-architects/module-federation-runtime has a unused dependency on angular.
I've created angular-architects/module-federation-plugin#324.
But we will probably need to fork the lib.

@mshima mshima changed the title add missing ignoredActionPaths to react config fix react admin menu using module federation. May 24, 2023
@mshima
Copy link
Member Author

mshima commented Oct 25, 2023

I've switched to @module-federation/utilities.
Should work now.

@mshima mshima marked this pull request as ready for review October 25, 2023 16:44
@mraible
Copy link
Contributor

mraible commented Oct 25, 2023

I'll take a look at this today.

Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch with the JDL from the issue it fixes. Everything works as expected!

@DanielFran DanielFran merged commit 293b073 into main Oct 26, 2023
29 checks passed
@DanielFran DanielFran deleted the skip_ci-react-mf branch October 26, 2023 07:43
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Administration menu doesn't work when creating micro frontends example with React
4 participants