Customize the Jackson2ObjectMapperBuilder instead of replacing it #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .featuresToDisable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS) | ||
| .findModulesViaServiceLoader(true) | ||
| .modulesToInstall(module); | ||
| public ObjectMapper myJacksonObjectMapper() { |
There was a problem hiding this comment.
Can you change the name to jacksonObjectMapper or customJacksonObjectMapper ?
|
Do you remove the old serializers for already created projects? |
|
I only keep the serializer for ZonedDateTime. |
|
I mean the physical files in |
|
Oh, yes ! Good point ! I'll add them ! |
also set INDENT_INPUT to true in dev profile Fix jhipster#3830
| */ | ||
| function cleanupOldServerFiles(generator, javaDir, testDir) { | ||
| if (generator.isJhipsterVersionLessThan('3.4.3')) { | ||
| generator.removeFile(javaDir + 'domain/util/JSR310DateTimeSerializer.java'); |
There was a problem hiding this comment.
I think it would be better to use generator.fs.delete() but there is currently an issue (yeoman/generator#950) so we can see about that later.
|
Lots of deleted code, cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also set INDENT_INPUT to true in dev profile
Fix #3830