Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for eclipse not activating dev profile by default and hence having issue #9175 #9369

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

pmverma
Copy link
Member

@pmverma pmverma commented Mar 4, 2019

Fix #9175.
Since profile id eclipse will be activated by default in eclipse IDE, dependency has been included there.

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@cbornet
Copy link
Member

cbornet commented Mar 4, 2019

@jhipster/developers Is there something preventing us to set the dependency in <dependencies /> instead of <build /> ? I think gradle already does it this way !

@PierreBesson
Copy link
Contributor

@cbornet +1, this would be a better solution. And can we remove the cc profile as well.

@jdubois
Copy link
Member

jdubois commented Mar 4, 2019

  • Yes let's remove "cc" I don't think anybody uses it
  • And for the "build" part: this was probably coded by me, and as far as I know it can be moved without any issue

@pmverma
Copy link
Member Author

pmverma commented Mar 4, 2019

@cbornet @PierreBesson @jdubois I think we should better create a new issue & PR for cleaning and refactoring pom.xml file. Let's close this PR.

I am not expert in configuring the pom.xml but I can help in it.
Is it only removing the cc profile and moving the dependency declaration inside <dependencies />?

@atomfrede
Copy link
Member

I would say create a separate PR for removing th cc profile and cleaning up the pom.

@mraible
Copy link
Contributor

mraible commented Mar 27, 2019

Closing as requested by @pmverma.

@mraible mraible closed this Mar 27, 2019
@pmverma
Copy link
Member Author

pmverma commented Mar 27, 2019

@mraible Sorry for my english. I meant to merge and close. This PR is still meant for #9175.
Can you please merge it?

@mraible mraible reopened this Mar 27, 2019
@mraible mraible merged commit 11b9226 into jhipster:master Mar 27, 2019
@pmverma pmverma deleted the fix-9175 branch March 27, 2019 16:03
@jdubois jdubois added this to the 6.0.0-beta.0 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile error (missing javax.Servlet and Undertow) while importing in eclipse
6 participants