Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to JHipster v8 #1340

Closed
nicolas63 opened this issue Sep 17, 2023 · 8 comments · Fixed by #1358, #1384, #1387, #1389 or #1388
Closed

Migrate to JHipster v8 #1340

nicolas63 opened this issue Sep 17, 2023 · 8 comments · Fixed by #1358, #1384, #1387, #1389 or #1388
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/

Comments

@nicolas63
Copy link
Member

Overview of the feature request

According jhipster/generator-jhipster#23449 JHipster v8 is getting close, we should migrate and make sure everything is working correctly.

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Sep 21, 2023
@mshima mshima mentioned this issue Sep 24, 2023
4 tasks
This was linked to pull requests Oct 7, 2023
This was linked to pull requests Oct 8, 2023
@nicolas63
Copy link
Member Author

Hi @mshima , after some tests I have a strange behavior when I generate a project and run npm install
After that I get this error when I run jhipster-dotnetcore again.

ERROR! ERROR! Package subpath './generators/entity' is not defined by "exports" in myfolder\node_modules\generator-jhipster-dotnetcore\node_modules\generator-jhipster\package.json
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './generators/entity' is not defined by "exports" in myfolder\node_modules\generator-jhipster-dotnetcore\node_modules\generator-jhipster\package.json
    at new NodeError (node:internal/errors:405:5)
    at exportsNotFound (node:internal/modules/esm/resolve:362:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:698:9)
    at resolveExports (node:internal/modules/cjs/loader:567:36)
    at Module._findPath (node:internal/modules/cjs/loader:636:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1063:27)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (myfolder\node_modules\generator-jhipster-dotnetcore\generators\entity\index.js:2:25) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Without npm install I don't get this error

@mshima
Copy link
Member

mshima commented Oct 29, 2023

@nicolas63 you probably got hit by jhipster/generator-jhipster#24028.
You can workaround by using —skip-jhipster-dependencies.

@nicolas63
Copy link
Member Author

@mshima who get this bounty ? You ? Me ? Both ?

@mshima
Copy link
Member

mshima commented Nov 27, 2023

The actual migration happened in #1358 with 158 commits, I am not sure why this bug was not closed since it had Fixes https://github.com/jhipster/jhipster-dotnetcore/issues/1340 in the description.
The following PRs documentations and adjusts.
I think split $100 for the review and adjusts $400 for migration and following adjust in my part is fair.

@nicolas63
Copy link
Member Author

totally agree with you, even if this ticket took me a bit of work, you've done most of it and thank you again for that.

@nicolas63
Copy link
Member Author

@mshima
Copy link
Member

mshima commented Dec 12, 2023

@DanielFran
Copy link
Member

@mshima approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
4 participants