Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP Deploy Button (using Cloud Run) to Readme #395

Closed

Conversation

SudharakaP
Copy link
Member

Working on jhipster/generator-jhipster#10345, I thought it would be beneficial to add a deploy button to GCP, similar to what we have for Heroku. Especially this will help with the microservice deployments on GCP.

Will finalize the PR once my testing is done 😄

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@SudharakaP SudharakaP force-pushed the add-gcp-cloud-run-deploy-button branch from f5e7d5b to dbe7687 Compare November 25, 2019 05:59
@SudharakaP
Copy link
Member Author

There's a problem with adding this button and using Cloud Run since the app.yaml file for Heroku clashes with the app.yaml for Cloud Run. I've opened an issue for this here; GoogleCloudPlatform/cloud-run-button#112

I am thinking of a solution to this. If anyone can think of a workaround for this problem let me know 😄

@SudharakaP
Copy link
Member Author

After some thinking about this, I am closing this since there seems to be some work done on the Cloud Run button side (as per GoogleCloudPlatform/cloud-run-button#112) before we can support this button. I'll add this in the future when that work is completed. 😄

@SudharakaP SudharakaP closed this Nov 26, 2019
@SudharakaP SudharakaP deleted the add-gcp-cloud-run-deploy-button branch November 27, 2019 05:40
@PierreBesson
Copy link
Contributor

I'm not a big fan of supporting this kind of button as we will have to do the support ourselves. When we added the Heroku button, it was supported by @jkutner who was paid by Heroku to work on this kind of stuff but this is my understanding that he changed roles at Heroku.
Apart from the wow factor, I don't think it is supporting any real use case to deploy the registry at the click of a button and we have had almost no feedback about it.
Also the fact that we have to keep a separate develop branch to not break the button by mistake is wasting our time and it's a source of confusion for external contributors.

@SudharakaP
Copy link
Member Author

@PierreBesson : Agreed. Thanks for the info. Thought it would be nice to have one since we have one already for Heroku. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants