feature: improve throws rendering #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
reviewed
Dec 3, 2019
| void throwException3(String string1, String string2, String string3) | ||
| throws RuntimeException { | ||
| void throwException3(String string1, String string2, String string3) throws | ||
| RuntimeException { |
There was a problem hiding this comment.
I'm a bit worried about the invariable split of the throws keyword from the exception(s).
FYI I've added a very late comment to #286 (comment)
Merged
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to fix #286
I'm not sure about how to format some cases so feedbacks are welcome
(cc @murdos as you are the one who created the issue)