Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compatibility with latest Webpack #18

Merged
merged 1 commit into from
Nov 9, 2015
Merged

Fixed compatibility with latest Webpack #18

merged 1 commit into from
Nov 9, 2015

Conversation

RSO
Copy link
Contributor

@RSO RSO commented Nov 9, 2015

As of webpack/webpack@5acfacf .Class
webpack is using Dependency::constructor over Dependency::Class. I
decided to keep the .Class for backwards compatibility.

Fixes #16

Fixed compatibility with latest Webpack
09fb779 
As of webpack/webpack@5acfacf `.Class`
webpack is using `Dependency::constructor` over `Dependency::Class`. I
decided to keep the `.Class` for backwards compatibility.

Fixes jhnns#16
jhnns added a commit that referenced this pull request Nov 9, 2015
@jhnns
Merge pull request #18 from Hacker0x01/fix-for-webpack
a6822f9 
Fixed compatibility with latest Webpack
@jhnns jhnns merged commit a6822f9 into jhnns:master Nov 9, 2015
@jhnns
Copy link
Owner

jhnns commented Nov 9, 2015

Damn! I wanted to publish this tonight, but somehow I was unable to install the dependencies. npm keeps installing rewire from the npm registry instead of GitHub (and rewire on npm does not contain a test folder).

Are you able to install it? Is something wrong with my local setup or is it a npm bug?

@barsukov
Copy link

Thank you guys, but this package is not on npm yet. Broke every my build... Try to use direct from github

@RSO
Copy link
Contributor Author

RSO commented Nov 11, 2015

@barsukov we're using this from the Hacker0x01/rewire-webpack@master now, and it fixes our problems.

@jhnns I will investigate and see if I can reproduce.

@RSO
Copy link
Contributor Author

RSO commented Nov 11, 2015

@jhnns yeah, it seems that installing from github now also uses the .npmignore file. Not sure when this got introduced, did a quick search but couldn't find anything. If other dependencies really need files inside of the test/ folder in rewire, wouldn't it make sense to remove it from the .npmignore file?

@jhnns
Copy link
Owner

jhnns commented Nov 11, 2015

If other dependencies really need files inside of the test/ folder in rewire, wouldn't it make sense to remove it from the .npmignore file

Mhmm yes ... that's probably true.

jhnns added a commit to jhnns/rewire that referenced this pull request Nov 14, 2015
@jhnns
Move shared test cases into lib folder
5a8ba82 
Since new versions of npm respect the .npmignore even when it comes
from git urls, we need to move the shared test cases into the lib folder
in order to provide these cases to other modules which port rewire's
functionality to other environments.

As discussed at jhnns/rewire-webpack#18
@jhnns
Copy link
Owner

jhnns commented Nov 15, 2015

This has finally been shipped with 1.0.1 😁

@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RSO @jhnns @barsukov