Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'coffeescript' package #127

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Conversation

odedniv
Copy link
Contributor

@odedniv odedniv commented Jan 16, 2018

The coffee-script package is old and deprecated (didn't update for a while, doesn't allow new JavaScript syntax). The new package is coffeescript.

This pull request:

  1. Tries loading coffeescript first and then coffee-script.
  2. Gives a proper message when trying to use coffeescript extension without coffeescript loaded (was previously TypeError: Cannot read property 'compile' of undefined).
  3. Changed the dev dependency.

I feel like coffeescript shouldn't be in devDependencies but in peerDependencies or something, but couldn't get it to work. Currently it simply cannot really fail loading coffeescript since it's a dependency.

Closes #126

@coveralls
Copy link

coveralls commented Jan 16, 2018

Coverage Status

Coverage decreased (-2.5%) to 97.458% when pulling 1250667 on odedniv:coffeescript-package into 18c5d0e on jhnns:master.

@jhnns jhnns mentioned this pull request Apr 9, 2018
@jhnns jhnns merged commit 1250667 into jhnns:master Apr 9, 2018
@odedniv odedniv deleted the coffeescript-package branch April 11, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants