Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ipmi::service class into ipmi::service::{ipmi,ipmievd) #5

Merged
merged 1 commit into from
Sep 14, 2013

Conversation

jhoblitt
Copy link
Owner

No description provided.

@jhoblitt
Copy link
Owner Author

@razorsedge What do you think of this? I can't seem to come up with parameter names that I like (and aren't long winded).

@razorsedge
Copy link
Contributor

In my snmp module, I have both the snmpd service as well as the snmptrapd service. The class parameters are named $service_ensure and $trap_service_ensure. The assumption is that the module name is snmp, so the service name parameter can be short while the trap service is extra and needs to have an additional name identifier.

I don't see an issue with what you have, but I'll throw out the suggestion of using $ipmi_service and $ipmievd_service.

@jhoblitt
Copy link
Owner Author

What do you think of $service_ensure and $ipmievd_service_ensure as suggested by https://github.com/stdmod/puppet-modules/blob/master/Parameters_List.md ?

@jhoblitt
Copy link
Owner Author

I'm going to merge this PR and make a v1.1.0 release. We can always change the API again later.

jhoblitt added a commit that referenced this pull request Sep 14, 2013
split ipmi::service class into ipmi::service::{ipmi,ipmievd)
@jhoblitt jhoblitt merged commit 8f04955 into master Sep 14, 2013
@razorsedge
Copy link
Contributor

I have yet to read all of stdmod, but those names look good.

@jhoblitt jhoblitt mentioned this pull request Sep 15, 2013
@jhoblitt jhoblitt deleted the service_control branch June 6, 2015 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants