ipmi::user: Mask passwords #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to move the passphrase to an env var. That would both prevent it from being logged and exposed in the process table. |
b4ldr
force-pushed
the
sensetive_password
branch
from
b7d332f
to
6e86c20
Compare
|
@jhoblitt updated thanks for the suggestion |
If an exec command fails then the entire command including passwords is included in the output. The CR updates the commands that have a password to be Sensitive ensuring the are redacted from output and logs.
|
Maybe try running the |
b4ldr
force-pushed
the
sensetive_password
branch
from
6e86c20
to
db1774f
Compare
|
@jhoblitt updated |
|
@jhoblitt wonder if I could get this merged and released? Thanks |
jhoblitt
approved these changes
Jan 16, 2024
|
Yes, this slipped off my radar. Thank you for contributing. |
|
This will be released in #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exec command fails, then the entire command including passwords is included in the output.
The CR updates the commands that have a password to be Sensitive, ensuring they are redacted from output and logs.