Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing out the newly implemented multi-css capability #198

Merged
merged 7 commits into from
Mar 10, 2023

Conversation

avahoffman
Copy link
Contributor

@avahoffman avahoffman commented Mar 9, 2023

in response to jhudsl/ottrpal#115

@KatherineCox @cansavvy I think this is working as expected!

Let's see how this one goes before

  • modifying the file structure of GDSCN, etc.
  • pushing the docker image to latest

I am about 80% sure the following chunk is okay to take out, due to the restored file path. If I'm wrong, I will fix :)

/* fix the image urls since our AnVIL style is in a different location */
/* images paths are relative to the CSS file */

div.notice{
  background-image: url("../box_images/note.png");
}

div.warning{
  background-image: url("../box_images/warning.png");
}

div.github{
  background-image: url("../box_images/github.png");
}

div.dictionary{
  background-image: url("../box_images/dictionary.png");
}

div.reflection{
  background-image: url("../box_images/thinking_face.png");
}

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

No broken urls! 🎉
Comment updated at 2023-03-09 with changes from 92ac44b

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

No spelling errors! 🎉
Comment updated at 2023-03-09 with changes from 92ac44b

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Re-rendered previews from the latest commit:

Updated at 2023-03-09 with changes from 92ac44b

@avahoffman
Copy link
Contributor Author

She works! Added an "ugly" color mod.

Regular:
Screen Shot 2023-03-09 at 5 50 30 PM
No ToC:
Screen Shot 2023-03-09 at 5 50 45 PM

@KatherineCox
Copy link
Collaborator

I'll take a look at everything when I'm at my computer, but yes, you should be good to drop those file paths 👍. I had to add them when I moved the style file down into the AnVIL assets directory, since paths are relative to the location of the css file.

Related, we'll want to update the sync.yml file in OTTR_Template so that the OTTR style.css file is syncing to the correct AnVIL_Template file.

Yay! This is exciting! Awesome work!!!

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! As long as it looks like it is working to you. One last step we’ll need to do is push the latest base_ottr docker image to have the main tag if we have confirmed the ottrpal updates are working as expected.

@avahoffman
Copy link
Contributor Author

This makes sense to me! As long as it looks like it is working to you. One last step we’ll need to do is push the latest base_ottr docker image to have the main tag if we have confirmed the ottrpal updates are working as expected.

Yes definitely. Would you rather (1) wait a bit to see if this causes any trouble here, or (2) just push now with the option to revert if need be? I am ok yolo'ing the image if you are!

@avahoffman avahoffman merged commit 36cb492 into main Mar 10, 2023
@avahoffman avahoffman deleted the multi-css-test branch March 10, 2023 14:32
@avahoffman
Copy link
Contributor Author

Well poop - needed to update render-all.yml as well 😛 : #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants