-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing out the newly implemented multi-css capability #198
Conversation
No broken urls! 🎉 |
No spelling errors! 🎉 |
Re-rendered previews from the latest commit:
Updated at 2023-03-09 with changes from 92ac44b |
I'll take a look at everything when I'm at my computer, but yes, you should be good to drop those file paths 👍. I had to add them when I moved the style file down into the AnVIL assets directory, since paths are relative to the location of the css file. Related, we'll want to update the sync.yml file in OTTR_Template so that the OTTR style.css file is syncing to the correct AnVIL_Template file. Yay! This is exciting! Awesome work!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me! As long as it looks like it is working to you. One last step we’ll need to do is push the latest base_ottr
docker image to have the main
tag if we have confirmed the ottrpal updates are working as expected.
Yes definitely. Would you rather (1) wait a bit to see if this causes any trouble here, or (2) just push now with the option to revert if need be? I am ok yolo'ing the image if you are! |
Well poop - needed to update |
in response to jhudsl/ottrpal#115
@KatherineCox @cansavvy I think this is working as expected!
Let's see how this one goes before
latest
I am about 80% sure the following chunk is okay to take out, due to the restored file path. If I'm wrong, I will fix :)