-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a PR template #126
Add a PR template #126
Conversation
Looks good! hmmm maybe we should add sections for how to include videos and embedded files and then include checklist items about checking the format? |
Yes sounds great! Would you be able to add that in a separate PR? That would help me to know how you do it as well! |
examples for videos: <iframe width="560" height="315" alt = "video of Russell McClain on biases and stereotypes" src="https://www.youtube.com/embed/yiZQaE0q9BY" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
Examples for embedded files:
<iframe src="https://widgets.figshare.com/articles/5427418/embed?show_title=1" width="568" height="351" allowfullscreen frameborder="0" alt = "expectation document"></iframe> |
Sure, I can do that. |
I have an appointment now so it will be in a bit... |
No rush! |
I assigned you to a separate issue for that @carriewright11 on #127 I think I will go ahead and merge this PR then assuming that there are no problems you've noticed otherwise. |
Closes #125 !
@carriewright11 anything you think needs to be added to the checklist or template in general?