-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringing over changes from main template #44
Conversation
Re-rendered previews from the latest commit: See preview of website here Updated at 2023-02-27 with changes from 7b4581f |
No spelling errors! 🎉 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carriewright11 Do you wanna take a look at these updates to see if they make sense to you?
@@ -15,10 +15,6 @@ group: | |||
dest: .github/workflows/docker-test.yml | |||
- source: .github/workflows/pull_request.yml | |||
dest: .github/workflows/render-site.yml | |||
- source: scripts/spell-check.R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repositories no longer need individual scripts with the use of ottr-reports github actions
@@ -18,7 +18,7 @@ jobs: | |||
|
|||
# Check out current repository | |||
- name: checkout | |||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be updated because of some github action items being deprecated
No spelling errors! :tada: | ||
_Comment updated at ${{ steps.build-components.outputs.time }} with changes from ${{ steps.build-components.outputs.commit_id }}_ | ||
edit-mode: replace | ||
uses: jhudsl/ottr-reports/.github/workflows/report-maker.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the ottr-reports calls look like. (A lot shorter and easier to manage! 🎉)
With the latest PRs from the main OTTR Template, there's some changes there that also will be needed here.
These changes in the main OTTR template reflect the changes that I'm making here: