Don't check URLs in ignore list #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
approved these changes
Aug 10, 2023
tmooney
added a commit
to griffithlab/Immuno_Workflow_Course
that referenced
this pull request
Jan 29, 2024
Now that jhudsl/ottr-reports#24 is merged, we should be able to turn this on without having it attempt to download the FASTQ tarballs each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue with the url-check.R script. The course site I am building contains links to some very large files, which cause the checker to fail. When I added those URLs to the
ignore-urls.txt, the script still failed since it tries toGETthe link (twice!) before throwing the results of the check away.This PR re-uses the status from the first
GETcall and also checks the ignore list inside oftest_url()reporting back a status ofignoredinstead ofsuccessorfailure. With these changes I was able to run the script on my project and have it report properly.That result is still filtered out before the report is made; I could imagine also removing the
dplyr::filter(!(urls %in% ignore_urls))from the end of the script since they still won't be included by thefailedfilter as is.