Supplying authorization to get slide notes for ottrpal

[cansavvy]

Purpose/implementation Section

What changes are being implemented in this Pull Request?

This was something we pair coded on. Basically if credentials aren't supplied we want to use a dummy credential to grab slides that are public anyway.

This code should do that with some encryption steps as well.

This is a PR based off the conversation here: #116 (comment)

[howardbaik]

If user provides the access_token and refresh_token as arguments, then this line won't be able to find decrypted object.

[cansavvy]

Oh right! We need to have this defined as access_token and refresh_token above in the if statement

[howardbaik]

Same comment as above: If user provides the access_token and refresh_token as arguments, then this line won't be able to find decrypted object.

[cansavvy]

Does this comment make sense? @howardbaek Do you know how to fix this? If not I can send suggestions.

[cansavvy]

Oh right! We need to have this defined as access_token and refresh_token above in the if statement

[howardbaik]

It seems like auth_from_secret() is a function that uses the "secrets" that we provided to the ottrpal R package to obtain a token. If so, should we just get rid of all the function arguments (access_token and refresh_token) so that when we run auth_from_secret(), we run this chunk no matter what:

decrypted <- openssl::aes_cbc_decrypt(
      readRDS(encrypt_creds_user_path()),
      key = readRDS(key_encrypt_creds_path())
)

and we create decrypted. When I supply a value to access_token and refresh_token, then the above code chunk doesn't run since its inside an if statement, and the following code chunk throws an error since it doesn't know what decrypted is:

  credentials <- list(
    access_token =  unserialize(decrypted)[[1]]$access_token,
    expires_in = 3599L,
    refresh_token = unserialize(decrypted)[[1]]$refresh_token,
    scope = scopes_list,
    token_type = "Bearer"
  )

[cansavvy]

@howardbaek this is what I was trying to describe to fix this. Let me know if this makes sense.

[cansavvy]

Suggested change

	)
	)
	access_token <- unserialize(decrypted)[[1]]$access_token
	refresh_token <- unserialize(decrypted)[[1]]$refresh_token

I'm doing this on my phone but this is what I'm suggesting you do. Bring the phrases from below up here (not sure if I typed these right) and declare the variables. Then below just specify access_token = access_token and same for refresh_token.

If this doesn't make sense, let me know and I'll send a commit later.

[howardbaik]

@cansavvy Looks good. Merged.