Citeproc Strikes Back: Add warning and fix syntax #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The windows error is not related to the changes in this PR. It's still related to the problem that I will try to address in #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background issues to this ongoing problem: #7 and #48
Basically you need a certain version of pandoc (greater than 2.11) to render citations properly. If you don't have greater than that before leanbuild would just break. Now I just have it give you a warning that the citations won't build but it will continue.
Also had my logic had the syntax incorrect so I had to fix that so that the question would be asked properly. Didn't realize in this particular instance numbers aren't actually treated like numbers in R. rmarkdown::pandoc_version() gives you a
numeric_versionwhich is different than a number. TIL.