Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this will remove the periods we need to get rid of #69

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

carriewright11
Copy link
Member

To fix issues with:

  1. images not being full size
  2. videos not being centered
  3. some images not being centered
  4. an extra period after images/videos

I think changing the ). to ) in the paste0 functions for adding the links to videos and images in R/replace_html.R should fix this.

@cansavvy
Copy link
Contributor

The fails are because I got rid of the example data and haven't yet addressed #56.

Looks like this fix should do the trick!

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this!

@cansavvy cansavvy merged commit ef42dc4 into master Sep 27, 2021
@cansavvy cansavvy deleted the rem_periods branch September 28, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants