"Solve the bug of multiple css queries with '>' #1753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffXiesk
changed the title
jhy
reviewed
May 17, 2022
| @@ -141,6 +141,7 @@ private void combinator(char combinator) { | |||
|
|
|||
| private String consumeSubQuery() { | |||
| StringBuilder sq = StringUtil.borrowBuilder(); | |||
| boolean is_new_class_query = false; | |||
There was a problem hiding this comment.
This is not Python... Please use Java and local style
jhy
reviewed
May 17, 2022
| else | ||
| tq.consume(); | ||
| else | ||
| else{ |
There was a problem hiding this comment.
I don't get why we're popping it off and then re-adding. Can't it just happen in one step? Seems kludgy
|
Please make sure the PR description includes an actual description of the change and what is wrong with the current implementation. Writing it like a user story like this doesn't help me understand the change and seems like a force fit. |
|
Please see previous comment - not inclined to merge as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1707
As a Jsoup user, I want to query some data from the Internet using multiple css queries so that I can improve the efficiency and do it more conveniently.