disable parse response header

jiacai2050 · Sep 16, 2023 · d43a7e1 · d43a7e1
1 parent a91a066
commit d43a7e1
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 39 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -29,7 +29,7 @@ jobs:
       - name: Install deps
         run: |
           sudo apt update && sudo apt install -y valgrind libcurl4-openssl-dev
-      - name: Run example
+      - name: Run examples
         run: zig build run-basic
       - name: Memory leak detect
         run: |
@@ -50,6 +50,6 @@ jobs:
       - uses: goto-bus-stop/setup-zig@v1
         with:
           version: master
-      - name: Build demo
+      - name: Run examples
         run: |
           zig build run-basic
diff --git a/examples/basic.zig b/examples/basic.zig
@@ -11,12 +11,13 @@ fn get(easy: Easy) !void {
         resp.status_code,
         resp.body.items,
     });
-    const date_header = try resp.get_header("date");
-    if (date_header) |h| {
-        std.debug.print("date header: {s}\n", .{h.get()});
-    } else {
-        std.debug.print("date header not found\n", .{});
-    }
+
+    // const date_header = try resp.get_header("date");
+    // if (date_header) |h| {
+    //     std.debug.print("date header: {s}\n", .{h.get()});
+    // } else {
+    //     std.debug.print("date header not found\n", .{});
+    // }
 }
 
 fn post(easy: Easy) !void {

diff --git a/src/easy.zig b/src/easy.zig
@@ -127,36 +127,38 @@ pub const Response = struct {
         self.body.deinit();
     }
 
-    pub const Header = struct {
-        c_header: *c.struct_curl_header,
-        name: []const u8,
-
-        /// Get gets the first value associated with the given key.
-        /// Applications need to copy the data if it wants to keep it around.
-        pub fn get(self: @This()) []const u8 {
-            return mem.sliceTo(self.c_header.value, 0);
-        }
-    };
-
-    pub fn get_header(self: @This(), name: []const u8) !?Header {
-        const c_name = try fmt.allocPrintZ(self.allocator, "{s}", .{name});
-        defer self.allocator.free(c_name);
-
-        var header: ?*c.struct_curl_header = null;
-        // https://curl.se/libcurl/c/curl_easy_header.html
-        const code = c.curl_easy_header(self.handle, name.ptr, 0, c.CURLH_HEADER, -1, &header);
-
-        // https://curl.se/libcurl/c/libcurl-errors.html
-        return switch (code) {
-            c.CURLHE_OK => .{
-                .c_header = header.?,
-                .name = name,
-            },
-            c.CURLHE_MISSING => null,
-            c.CURLHE_BADINDEX => error.BadIndex,
-            else => error.HeaderOther,
-        };
-    }
+    // Parse response header using `curl_easy_header` require libcurl >= 7.84.0.
+    // Find other solution to parse.
+    // pub const Header = struct {
+    //     c_header: *c.struct_curl_header,
+    //     name: []const u8,
+
+    //     /// Get gets the first value associated with the given key.
+    //     /// Applications need to copy the data if it wants to keep it around.
+    //     pub fn get(self: @This()) []const u8 {
+    //         return mem.sliceTo(self.c_header.value, 0);
+    //     }
+    // };
+
+    // pub fn get_header(self: @This(), name: []const u8) !?Header {
+    //     const c_name = try fmt.allocPrintZ(self.allocator, "{s}", .{name});
+    //     defer self.allocator.free(c_name);
+
+    //     var header: ?*c.struct_curl_header = null;
+    //     // https://curl.se/libcurl/c/curl_easy_header.html
+    //     const code = c.curl_easy_header(self.handle, name.ptr, 0, c.CURLH_HEADER, -1, &header);
+
+    //     // https://curl.se/libcurl/c/libcurl-errors.html
+    //     return switch (code) {
+    //         c.CURLHE_OK => .{
+    //             .c_header = header.?,
+    //             .name = name,
+    //         },
+    //         c.CURLHE_MISSING => null,
+    //         c.CURLHE_BADINDEX => error.BadIndex,
+    //         else => error.HeaderOther,
+    //     };
+    // }
 };
 
 pub fn init(allocator: mem.Allocator) !Self {
@@ -165,7 +167,7 @@ pub fn init(allocator: mem.Allocator) !Self {
         return error.Init;
     }
 
-    return Self{
+    return .{
         .allocator = allocator,
         .handle = handle.?,
     };