RATIS-2149.Do not perform leader election if the current RaftServer h…

…as not started yet (apache#1143)
jianghuazhu · Sep 7, 2024 · 3e38e6d · 3e38e6d
1 parent d1e76cf
commit 3e38e6d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java b/ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java
@@ -241,6 +241,10 @@ public void run() {
     }
 
     try (AutoCloseable ignored = Timekeeper.start(server.getLeaderElectionMetrics().getLeaderElectionTimer())) {
+      if (!server.isRunning()) {
+        LOG.info("{}: skip since the server is not running", this);
+        return;
+      }
       for (int round = 0; shouldRun(); round++) {
         if (skipPreVote || askForVotes(Phase.PRE_VOTE, round)) {
           if (askForVotes(Phase.ELECTION, round)) {

diff --git a/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java b/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
@@ -1911,4 +1911,8 @@ public RaftServerMetricsImpl getRaftServerMetrics() {
   void onGroupLeaderElected() {
     transferLeadership.complete(TransferLeadership.Result.SUCCESS);
   }
+
+  boolean isRunning() {
+    return startComplete.get() && lifeCycle.getCurrentState() == State.RUNNING;
+  }
 }