RATIS-2145. Follower hangs until the next trigger to take a snapshot. (…

…apache#1139)
jianghuazhu · Aug 30, 2024 · dfed101 · dfed101
1 parent 520ecab
commit dfed101
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java b/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
@@ -444,7 +444,7 @@ private void sendRequest(AppendEntriesRequest request,
   }
 
   private void timeoutAppendRequest(long cid, boolean heartbeat) {
-    final AppendEntriesRequest pending = pendingRequests.handleTimeout(cid, heartbeat);
+    final AppendEntriesRequest pending = pendingRequests.remove(cid, heartbeat);
     if (pending != null) {
       final int errorCount = replyState.process(Event.TIMEOUT);
       LOG.warn("{}: Timed out {}appendEntries, errorCount={}, request={}",
@@ -964,9 +964,5 @@ AppendEntriesRequest remove(AppendEntriesReplyProto reply) {
     AppendEntriesRequest remove(long cid, boolean isHeartbeat) {
       return isHeartbeat ? heartbeats.remove(cid): logRequests.remove(cid);
     }
-
-    public AppendEntriesRequest handleTimeout(long callId, boolean heartbeat) {
-      return heartbeat ? heartbeats.remove(callId) : logRequests.get(callId);
-    }
   }
 }