Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert int64 TargetIdentifier to string for TypeString schema #360

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

jwoo0122
Copy link
Contributor

@jwoo0122 jwoo0122 commented Dec 18, 2023

Fix an error when metric alert resource uses target identifier as integer. As TargetIdentifier type is TypeString, Int64 value cannot be used.

Related:

#185

@jianyuan
Copy link
Owner

Many thanks for this, @jwoo0122!

@jianyuan jianyuan merged commit b4b3e26 into jianyuan:main Dec 18, 2023
2 of 5 checks passed
@jwoo0122
Copy link
Contributor Author

Maybe there is a convention for release, but can you release this update soon?

@jwoo0122 jwoo0122 changed the title fix: convert int64 to string for TypeString schema fix: convert int64 TargetIdentifier to string for TypeString schema Dec 18, 2023
@jianyuan
Copy link
Owner

Maybe there is a convention for release, but can you release this update soon?

Aiming for tomorrow!

@jianyuan
Copy link
Owner

@jwoo0122 v0.12.1 is now out!

@jwoo0122
Copy link
Contributor Author

@jwoo0122 v0.12.1 is now out!

Awesome, I can see the problem fixed! Thanks a lot 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants