Add support for oracular/v19 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jidicula
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Hey, thanks for your contribution! This needs to be broken into 2 PRs, like I did for #182 and #183 - in the first PR, we add the new image to the autobuilds that are published to ghcr.io, then the 2nd PR references that image once it's published.
If you're not able to address those requested changes by the weekend, don't worry about it and I'll make them myself and add you as co-author on them 🙂.
|
@jidicula Thanks, will do! Updated this one to be image only. |
jidicula
approved these changes
Nov 27, 2024
|
@RichLogan I've approved and merged! Whenever you're ready, you can submit the 2nd PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for clang-format-19 via Ubuntu 24.10
Resolves #219