Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove formatting from manga synposis #320

Closed
CountryTk opened this issue Jul 20, 2020 · 8 comments
Closed

Don't remove formatting from manga synposis #320

CountryTk opened this issue Jul 20, 2020 · 8 comments
Assignees
@irfan-dahir
Labels
enhancement refactoring/speeding up

Comments

@CountryTk
Copy link

Right now the REST API just returns the synopsis with no newlines or anything. Tested with manga "Akumetsu" (mal_id: 1101).
@irfan-dahir
Copy link
Collaborator

irfan-dahir commented Jul 20, 2020 •
edited
Loading

Hi, formatting is not removed. The synopsis is parsed from a meta tag. Which is why there is no formatting.

@CountryTk
Copy link
Author

Is there a way to fix it? Or do I just have to manually scrape MAL myself to get those correct paragraph linebreaks?

@irfan-dahir
Copy link
Collaborator

Will look into it the feasibility

@irfan-dahir irfan-dahir transferred this issue from jikan-me/jikan-rest Sep 6, 2020
@irfan-dahir irfan-dahir moved this to Planned in Jikan PHP API May 24, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This issue will be closed and archived in 18 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This issue will be closed and archived in 18 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.

@nerg4l nerg4l removed the archived label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This issue will be closed and archived in 18 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.

@nerg4l nerg4l removed the archived label Nov 8, 2022
@pushrbx
Copy link
Collaborator

pushrbx commented Nov 8, 2022 •
edited
Loading

the anime part of this is fixed in #496
Fix for manga is still pending.

@pushrbx pushrbx added the in progress Features/Issues that are in progress of being completed/fixed label Nov 8, 2022
@irfan-dahir irfan-dahir added this to the 5.0.0 milestone Jul 21, 2023
@irfan-dahir irfan-dahir self-assigned this Sep 20, 2024
irfan-dahir added a commit that referenced this issue Sep 20, 2024
@irfan-dahir
techdebt🍴: parse manga synopsis with line-breaks #320
dcb4723
@irfan-dahir irfan-dahir added enhancement refactoring/speeding up and removed in progress Features/Issues that are in progress of being completed/fixed labels Sep 20, 2024
@irfan-dahir irfan-dahir removed this from the 5.0.0 milestone Sep 20, 2024
@irfan-dahir
Copy link
Collaborator

Fixed with release v4.0.12.

Note: On the public REST API, please wait 24-48 hours for any existing cache to be replaced.

@github-project-automation github-project-automation bot moved this from Planned to Done in Jikan PHP API Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irfan-dahir irfan-dahir

Labels
enhancement refactoring/speeding up
Projects
Jikan PHP API
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nerg4l @pushrbx @irfan-dahir @CountryTk