-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Likhith/76893/ts migrate linear progress label #38
Changes from all commits
b246e82
46d10ed
83c577f
24f9a31
39be93a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import './linear-progress.scss'; | ||
import LinearProgressContainer from './linear-progress-container.jsx'; | ||
import LinearProgressContainer from './linear-progress-container'; | ||
|
||
export default LinearProgressContainer; |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import classNames from 'classnames'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we are not adding any dynamic classnames here.is this import required? |
||
import React from 'react'; | ||
|
||
type TLinearProgress = { | ||
progress: number; | ||
className?: string; | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we need className and height in this component? I couldn't find using them in the component. |
||
|
||
export const LinearProgress = ({ progress, className }: TLinearProgress) => ( | ||
<div className={classNames('dc-linear-progress', className)}> | ||
<div className='dc-linear-progress__bar' style={{ width: `${progress}%` }} /> | ||
</div> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just check whether all these props are required. Rest is LGTM