forked from deriv-com/deriv-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shayan/77946/account switcher is breaking in mobile ios #63
Merged
jim-deriv
merged 9 commits into
jim-deriv:components-shared-ts-migration-parent
from
shayan-deriv:shayan/77946/account-switcher-is-breaking-in-mobile-ios
Oct 13, 2022
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5303d92
Merge branch 'master' of github.com:binary-com/deriv-app
daffd0f
Merge branch 'master' of github.com:binary-com/deriv-app
f3dc20c
Merge branch 'master' of github.com:binary-com/deriv-app
df97783
Merge branch 'master' of github.com:iman-fs/deriv-app
f8e3530
Merge branch 'master' of github.com:binary-com/deriv-app
5919bf8
fix: fixed building error and add type to react-div-100vh
beb465e
Merge branch 'components-shared-ts-migration-parent' of github.com:ji…
efdabbe
chore: removed empty line
04a4e2e
fix: resove pr comments and updated package-lock
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
packages/components/@types/react-div-100vh/react-div-100vh-config.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
declare module 'react-div-100vh' { | ||
export default function Div100vh( | ||
props: React.PropsWithChildren<{ | ||
className: string | undefined; | ||
id: string | undefined; | ||
style: { | ||
height?: string | null; | ||
maxHeight?: string | null; | ||
}; | ||
}> | ||
): JSX.Element; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since
NX
couldnt pickreact-div-100vh-config.d.ts
when building if it was defined inside the root ofcore
workspace, I moved it topackages/components/@types/react-div-100vh/react-div-100vh-config.d.ts
as it was suggested in [here](nrwl/nx#5825), and added this line to this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding
typeRoots
config totsconfig
would make the same effect and we wouldn’t need to reference the type in the file itself 🤔 Not sure if it will work with NX or not