Enhance memory management and reliability in RTSP server #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored audio and video track handling to utilize `ReadOnlySequence<byte>` for better performance and memory efficiency. - Introduced `AdjustedSizeMemoryOwner` for effective memory allocation. - Updated method signatures for RTP packet creation and sample feeding to accept `ReadOnlySequence<byte>`, ensuring consistency and optimizing memory usage. - Modified `RTPPacketUtil` to read timestamps from `ReadOnlySpan<byte>`, enhancing performance. - Overall code structure refined for improved readability and memory management.
paulomorgado
force-pushed
the
performance
branch
from
3b3c63d to
8a24609
Compare
|
When it comes to SharpOnvifServer library changes, the only concern I have regarding these new APIs is the netstandard2.0 (in)compatibility. It might require using a polyfill such as https://github.com/[meziantou/Meziantou.Polyfill](https://github.com/meziantou/Meziantou.Polyfill) - this should be the same one SharpRTSP is already using, so it will not introduce any additional dependency if possible. |
|
Making these changes helps me understand the library. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might look a bit extreme, but the intention is to assure to the caller that the data provided won't be modified by using
ReadOnlySequence<byte>instead ofList<byte[]>and reduce memory allocated byITrackimplementations.Changes:
ReadOnlySequence<byte>for better performance and memory efficiency.AdjustedSizeMemoryOwnerfor effective memory allocation.ReadOnlySequence<byte>, ensuring consistency and optimizing memory usage.RTPPacketUtilto read timestamps fromReadOnlySpan<byte>, enhancing performance.