Select from available addreses dropdown #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
This is handy! Thanks for the PR! @jimmychu0807 you wanna get this in?
|
@marlowl lgtm. Thanks for the contribution |
|
@jimmychu0807 @nukemandan thanks for reviewing! |
jimmychu0807
added a commit
that referenced
this pull request
Mar 5, 2022
* Update polkadot-js url's (#220) * Select from available addreses dropdown (#222) * select from available addreses dropdown * fix linter * Fix console warning (#224) * select from available addreses dropdown * fix linter * Fix console warning message Co-authored-by: marlowl <marlowlieshout@hotmail.com> * Multiple fixes (`monthly-2022-01` tag) (#225) * Remove the traces on custom type and update to based on Node v16 * webpack 5 migration * Rm eslint related dev-dependencies & use URLSearchParams over querystring * Updated to the latest polkadot-js libs * Integrate with prettier * Friendlier connection failure message. * Refactored current selected account into SubstrateContext * bugfix * Fix console warning * Update README * Update to solve a yarn berry issue * Updating for CI (#226) * Fixing (#227) * Supporting bigInt in production and reading rpc query parameter correctly * Fixing issue when React strict mode is enabled, and better logic for keyring initialization * Updating README (#228) * Fixing issue when there is no accounts can be selected (#230) * Fixing issue when there is no accounts can be selected * prettier * Fix to support polkadot-js extension (#231) * Dynamically check if connecting chain is in dev mode (#232) * Minor update (#233) * update all deps (#238) * TxButton enhancement & general packages maintenance (#239) * dev (wip) * Using prettier and added eslint for project * Using the latest package without changing package.json * eslint:write & prettier:write Co-authored-by: Stéphane P <n3wborn@protonmail.com> Co-authored-by: marlowl <30845815+marlowl@users.noreply.github.com> Co-authored-by: marlowl <marlowlieshout@hotmail.com> Co-authored-by: Dan Shields <35669742+NukeManDan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with the substrate playground and thought this might be a nice little addition.
Since this is my first pull request on this repo, I'm open to any feedback on the feature or code! 😄