Update ordering of overrides so ReturnType pulls correct typing. #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the ordering of the loadFont overrides so that when ReturnType is used to capture the returned type from `typeof Jimp.loadFont` it will receive the correct type definitions. EG: ```ts private FONT_SANS_16_BLACK: Awaited<ReturnType<typeof Jimp.loadFont>>; ``` Current: ``` Type 'Font' is not assignable to type 'never'.ts(2322) ``` Expected: No Error, Font typed as `Font`
|
Can someone please re-run https://app.circleci.com/pipelines/github/oliver-moran/jimp/302/workflows/03243568-1f6a-4426-8b55-f31d61380900/jobs/1282. This looks like it failed due to an unrelated timeout. That test might need an adjustment in timeout timing. |
|
Anyone maintaining this repository? I'd like to have this merged upstream so I can stop running a custom fork. |
hipstersmoothie
approved these changes
Feb 4, 2023
# Conflicts: # packages/plugin-print/index.d.ts
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
This updates the ordering of the loadFont overrides so that when ReturnType is used to capture the returned type from
typeof Jimp.loadFontit will receive the correct type definitions.EG:
Current:
Expected:
No Error, Font typed as
FontWhat else might be affected
Should have no other side-effects
Tasks
jimp.d.ts