Support syntax change for call in Ruby 2.6 #15
Conversation
In Ruby 2.5.5, Ripper::SexpBuilder.new(thing.stuff).parse gives this output: [:program, [:stmts_add, [:stmts_new], [:call, [:vcall, [:@Ident, thing, [1, 0]]], :., [:@Ident, stuff, [1, 6]]]]] but in Ruby 2.6.2, it gives this output: [:program, [:stmts_add, [:stmts_new], [:call, [:vcall, [:@Ident, thing, [1, 0]]], [:@period, ., [1, 5]], [:@Ident, stuff, [1, 6]]]]] This means it is no longer safe to assume that the third item in the :call array can be emitted without any processing, and we need to call resource on it
|
Hi @segunn. I've attained write access to sorcerer on rubygems.org so I've forked the repo to the rspec-given org here: https://github.com/rspec-given/sorcerer Would you mind sending this PR there and helping by getting |
|
Any idea when this might happen? I can make the PR if that's all that's needed. Regards, |
|
Apologies for the delay - I'd been hoping to find time to also fix the pre-existing broken tests but haven't managed it yet. I've made the PR with just this change for now |
|
For the record @yb66 & @segunn, this was merged into the rspec-given org fork of sorcerer: rspec-given#1 However, because I had problems getting the tests to run and pass I was wary of pushing a new version to RubyGems at the time |
|
Ok, this is landed in sorcerer@2.0.0 after lots of build fixes |
In Ruby 2.5.5, Ripper::SexpBuilder.new(thing.stuff).parse gives this output:
[:program,
[:stmts_add,
[:stmts_new],
[:call,
[:vcall, [:@Ident, thing, [1, 0]]],
:.,
[:@Ident, stuff, [1, 6]]]]]
but in Ruby 2.6.2, it gives this output:
[:program,
[:stmts_add,
[:stmts_new],
[:call,
[:vcall, [:@Ident, thing, [1, 0]]],
[:@period, ., [1, 5]],
[:@Ident, stuff, [1, 6]]]]]
This means it is no longer safe to assume that the third item in the :call array can be emitted without any processing, and we need to call resource on it