Projection mode in rendering.py

[Yarkane]

Hello there.

We started to implement orthographic projection in our project. From what I understand, the Orthographic mode of projection has to be defined when initializing the View object.

But as we can see in this screen, "projection" is not used in the function. I edited the line
ViewCommon.__init__(self, scene, projection=None, navigation=None)
to
ViewCommon.__init__(self, scene, projection=projection, navigation=None)
and called the function giving as an argument a madcad.rendering.Orthographic() object.
which resumed to what I expected : an orthographic view.

Why is it necessary to change the code in rendering.py ? Is there a reason why it has been "disabled" in the code ?

Thanks in advance !

[jimy-byerley]

No reason at all, I think I just made a wrong copy-paste at some moment I was refactoring ViewCommon and never noticed these parameters were not working anymore because I personally always use the defaults from the configuration.
Thanks for noticing me ! I will change that in the next release.

I should however check that all the methods of View still work with the orthographic projection. I didn't tested it in the past year, so other things might be broken too :-/

[Yarkane]

Thanks a lot for the answer ! Keep me in touch as possible :)

[jimy-byerley]

Finally the fix is released in v0.13, in addition with a rework of Orthographic projection, so I'm sure it will work starting from now ;)