Skip to content

Commit

Permalink
fix: docker push action
Browse files Browse the repository at this point in the history
  • Loading branch information
numb3r3 committed May 23, 2022
1 parent ea7f535 commit f906c74
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/force-docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ jobs:
fi
PIP_TAG=${{ matrix.pip_tag }}
BACKEND_TAG=torch
if [ -n "${PIP_TAG}" ]; then
PIP_TAG=-${PIP_TAG}
BACKEND_TAG=${PIP_TAG}
fi
if [[ "${{ github.event.inputs.triggered_by }}" == "CD" ]]; then
Expand Down Expand Up @@ -80,6 +82,7 @@ jobs:
fi
echo "CAS_VERSION=${CAS_VERSION}" >> $GITHUB_ENV
echo "BACKEND_TAG=${BACKEND_TAG}" >> $GITHUB_ENV
- name: Set up Docker Buildx
id: buildx
Expand Down Expand Up @@ -113,6 +116,7 @@ jobs:
CAS_VERSION=${{env.CAS_VERSION}}
VCS_REF=${{env.VCS_REF}}
PIP_TAG=${{matrix.pip_tag}}
BACKEND_TAG=${{env.BACKEND_TAG}}
- name: CUDA Build and push
id: cuda_docker_build
if: ${{ matrix.engine_tag == 'cuda' }}
Expand All @@ -130,3 +134,4 @@ jobs:
CAS_VERSION=${{env.CAS_VERSION}}
VCS_REF=${{env.VCS_REF}}
PIP_TAG=${{matrix.pip_tag}}
BACKEND_TAG=${{env.BACKEND_TAG}}
4 changes: 2 additions & 2 deletions Dockerfiles/base.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ARG JINA_VERSION=3.3.25
FROM jinaai/jina:${JINA_VERSION}-py38-standard

ARG PIP_TAG
ARG DL_ENGINE=torch
ARG BACKEND_TAG=torch

# constant, wont invalidate cache
LABEL org.opencontainers.image.vendor="Jina AI Limited" \
Expand All @@ -24,7 +24,7 @@ RUN echo "\
jtype: CLIPEncoder\n\
metas:\n\
py_modules:\n\
- server/clip_server/executors/clip_$DL_ENGINE.py\n\
- server/clip_server/executors/clip_$BACKEND_TAG.py\n\
" > /tmp/config.yml

RUN cd /clip-as-service && \
Expand Down
4 changes: 2 additions & 2 deletions Dockerfiles/cuda.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ENV DEBIAN_FRONTEND=noninteractive

ARG JINA_VERSION=3.3.25
ARG PIP_TAG
ARG DL_ENGINE=torch
ARG BACKEND_TAG=torch

RUN apt-get update && apt-get install -y --no-install-recommends \
python3-setuptools python3-wheel python3-pip \
Expand All @@ -26,7 +26,7 @@ with:\n\
device: cuda\n\
metas:\n\
py_modules:\n\
- server/clip_server/executors/clip_$DL_ENGINE.py\n\
- server/clip_server/executors/clip_$BACKEND_TAG.py\n\
" > /tmp/config.yml

RUN cd /clip-as-service && \
Expand Down

0 comments on commit f906c74

Please sign in to comment.