Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update executor docstring #806

Merged
merged 4 commits into from
Aug 16, 2022
Merged

chore: update executor docstring #806

merged 4 commits into from
Aug 16, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Aug 16, 2022

This pr adds docstring to CLIP executors
Also fix some typo and misinformation in the docs

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #806 (1a2f80e) into main (3c43eed) will decrease coverage by 2.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   84.10%   81.85%   -2.26%     
==========================================
  Files          21       21              
  Lines        1466     1466              
==========================================
- Hits         1233     1200      -33     
- Misses        233      266      +33     
Flag Coverage Δ
cas 81.85% <ø> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_onnx.py 84.05% <ø> (ø)
server/clip_server/executors/clip_tensorrt.py 92.72% <ø> (ø)
server/clip_server/executors/clip_torch.py 82.53% <ø> (ø)
server/clip_server/model/trt_utils.py 56.04% <0.00%> (-27.48%) ⬇️
server/clip_server/model/clip_trt.py 69.38% <0.00%> (-16.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

📝 Docs are deployed on https://ft-exec-docstring--jina-docs.netlify.app 🎉

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 89205f0 into main Aug 16, 2022
@numb3r3 numb3r3 deleted the exec-docstring branch August 16, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants