Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dynamic batching param #6203

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: use dynamic batching param #6203

merged 1 commit into from
Sep 23, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 23, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.51%. Comparing base (d48f5a3) to head (4c711f1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
jina/serve/runtimes/worker/request_handling.py 0.00% 4 Missing ⚠️
jina/serve/executors/decorators.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d48f5a3) and HEAD (4c711f1). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (d48f5a3) HEAD (4c711f1)
jina 12 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6203       +/-   ##
===========================================
- Coverage   55.91%   40.51%   -15.40%     
===========================================
  Files         150      150               
  Lines       14217    14219        +2     
===========================================
- Hits         7949     5761     -2188     
- Misses       6268     8458     +2190     
Flag Coverage Δ
jina 40.51% <16.66%> (-15.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM force-pushed the add-use_dyn_batch_config branch from 4c711f1 to 515a121 Compare September 23, 2024 10:43
@JoanFM JoanFM closed this Sep 23, 2024
@JoanFM JoanFM reopened this Sep 23, 2024
@JoanFM JoanFM force-pushed the add-use_dyn_batch_config branch from 515a121 to 35c2561 Compare September 23, 2024 12:26
@JoanFM JoanFM force-pushed the add-use_dyn_batch_config branch from 35c2561 to 140721d Compare September 23, 2024 13:22
@github-actions github-actions bot added the area/setup This issue/PR affects setting up Jina label Sep 23, 2024
@JoanFM JoanFM force-pushed the add-use_dyn_batch_config branch from 140721d to 0e41f7d Compare September 23, 2024 13:28
@JoanFM JoanFM marked this pull request as ready for review September 23, 2024 14:19
@JoanFM JoanFM merged commit 338ac3f into master Sep 23, 2024
127 of 129 checks passed
@JoanFM JoanFM deleted the add-use_dyn_batch_config branch September 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/client size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant