Update package.json's license section #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [NPM's "License" section](https://docs.npmjs.com/files/package.json#license), multiple licenses should be formatted differently. This will help license validators to parse them correctly.
ljharb
approved these changes
May 29, 2019
|
please merge this! This is mandatory when using |
ihbar
suggested changes
Oct 10, 2019
There was a problem hiding this comment.
It seems that license rule has been update don npmjs, and the proposed solution is now deprecated.
The prefered solution is a SPDX expression :
"If your package is licensed under multiple common licenses, use an SPDX license expression syntax version 2.0 string, like this:{ "license" : "(ISC OR GPL-3.0)" }"
So it should be "license" : "(LGPL-2.0 OR MIT)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to NPM's "License" section, multiple licenses should be formatted differently. This will help license validators to parse them correctly.