Skip to content

Commit

Permalink
Merge pull request kubernetes#46489 from xilabao/de-duplication-of-verb
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946)

De-duplication of verb in policy.go

**What this PR does / why we need it**:
https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go#L224 contains `get` verb. 

**Which issue this PR fixes**:

**Special notes for your reviewer**:

**Release note**:

```release-note
None
```
  • Loading branch information
Kubernetes Submit Queue authored May 30, 2017
2 parents 657c01c + 35acfde commit 61693bf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func ClusterRoles() []rbac.ClusterRole {
// TODO: remove once mirror pods are removed
// TODO: restrict deletion to mirror pods created by the bound node once supported
// Needed for the node to create/delete mirror pods
rbac.NewRule("get", "create", "delete").Groups(legacyGroup).Resources("pods").RuleOrDie(),
rbac.NewRule("create", "delete").Groups(legacyGroup).Resources("pods").RuleOrDie(),
// TODO: restrict to pods scheduled on the bound node once supported
rbac.NewRule("update").Groups(legacyGroup).Resources("pods/status").RuleOrDie(),

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,6 @@ items:
verbs:
- create
- delete
- get
- apiGroups:
- ""
resources:
Expand Down

0 comments on commit 61693bf

Please sign in to comment.