Add GA-only conformance job to master-blocking

jingzhang36 · Mar 7, 2020 · 0b91a68 · 0b91a68
1 parent 1da4fe1
commit 0b91a68
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/config/jobs/kubernetes/sig-testing/conformance-e2e.yaml b/config/jobs/kubernetes/sig-testing/conformance-e2e.yaml
@@ -271,6 +271,7 @@ periodics:
   annotations:
     testgrid-num-failures-to-alert: '2'
     testgrid-alert-stale-results-hours: '48'
-    testgrid-dashboards: conformance-all, conformance-kind, sig-testing-kind
+    testgrid-dashboards: sig-release-master-blocking, conformance-all, conformance-kind, sig-testing-kind
     testgrid-tab-name: conformance-ga-only
-    testgrid-alert-email: liggitt@google.com
+    testgrid-alert-email: "kubernetes-release-team@googlegroups.com, kubernetes-sig-architecture@googlegroups.com"
+    description: "OWNER: sig-architecture (conformance); conformance tests run against a master kind cluster with only GA APIs and features enabled"
diff --git a/config/tests/testgrids/config_test.go b/config/tests/testgrids/config_test.go
@@ -471,13 +471,13 @@ func TestReleaseBlockingJobsMustHaveTestgridDescriptions(t *testing.T) {
 					t.Logf("NOTICE: %v: - Must have a description that starts with OWNER: ", intro)
 				}
 				if dashboardtab.AlertOptions == nil {
-					t.Logf("NOTICE: %v: - Must have alert_options", intro)
+					t.Logf("NOTICE: %v: - Must have alert_options (ensure informing dashboard is listed first in testgrid-dashboards)", intro)
 				} else if dashboardtab.AlertOptions.AlertMailToAddresses == "" {
 					t.Logf("NOTICE: %v: - Must have alert_options.alert_mail_to_addresses", intro)
 				}
 			} else {
 				if dashboardtab.AlertOptions == nil {
-					t.Errorf("%v: - Must have alert_options", intro)
+					t.Errorf("%v: - Must have alert_options (ensure blocking dashboard is listed first in testgrid-dashboards)", intro)
 				} else if dashboardtab.AlertOptions.AlertMailToAddresses == "" {
 					t.Errorf("%v: - Must have alert_options.alert_mail_to_addresses", intro)
 				}