Fix division remainder operator (%) #272
Merged
+8
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #271
Jinja2Cpp's
%
operator differs from%
of the original Jinja library.For example the expression {{ 11 % 7 }} in Jinja2Cpp shows
-3
, while the original Jinja shows4
.Here is a link to the documentation of the original Jinja:
% Calculate the remainder of division. For instance, 11 % 7 returns 4.
The reason why Jinja2Cpp differs from the original Jinja is because Jinja2Cpp uses
std::remainder
instead ofstd::fmod
.This PR replaces
std::remainder
withstd::fmod
, adds a test for the%
operator and also fixes a typo in the name of theDivReminder
variable by renaming it toDivRemainder
.