Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to select version when using particular commit #305

Closed
yyoncho opened this issue Jan 30, 2023 · 2 comments
Closed

Fails to select version when using particular commit #305

yyoncho opened this issue Jan 30, 2023 · 2 comments
Assignees
@jiro4989
Labels
bug Something isn't working

Comments

@yyoncho
Copy link

yyoncho commented Jan 30, 2023

Describe the bug

choosenim supports using commit id, e. g. #branch-name, #commit-id. It seems like setup-nim-action fails to do so.

To Reproduce


on:
  push:
  pull_request:
  schedule:
  - cron: "0 19 * * *"

jobs:
  test:
    strategy:
      matrix:
        os:
          - ubuntu-latest
        nimversion:
          - "#version-1-6"
    name: ${{ matrix.os }} - ${{ matrix.nimversion }}
    runs-on: ${{ matrix.os }}
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    steps:
      - uses: actions/checkout@v3
      - uses: jiro4989/setup-nim-action@v1.4.1
        with:
          nim-version: ${{ matrix.nimversion }}
          yes: true
      - name: Install Mercurial on macOS
        run: nim --version

Expected behavior

the correct version is installed properly

Screenshots or Logs

https://github.com/yyoncho/langserver/actions/runs/4045771119/jobs/6957691462

  • OS: any
  • Version: latest

Additional context
@yyoncho yyoncho added the bug Something isn't working label Jan 30, 2023
@jiro4989 jiro4989 mentioned this issue Jan 30, 2023
Merged
jiro4989 added a commit that referenced this issue Jan 31, 2023
@jiro4989
fix: fail to install when version has a comment marker #305 (#306)
e9bedea 
* chore: add test case

* fix: version to string

* Revert "fix: version to string"

This reverts commit 7e08170.

* fix: exec to execFile
@jiro4989
Copy link
Owner

jiro4989 commented Jan 31, 2023 •
edited
Loading

@yyoncho I Fixed it.
https://github.com/jiro4989/setup-nim-action/releases/tag/v1.4.3

@yyoncho
Copy link
Author

yyoncho commented Jan 31, 2023

Thank you!

@yyoncho yyoncho closed this as completed Jan 31, 2023
yyoncho added a commit to yyoncho/langserver that referenced this issue Jan 31, 2023
@yyoncho
Incorporate jiro4989/setup-nim-action#305
411304d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiro4989 jiro4989

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyoncho @jiro4989