Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Battery Indicator / Generic Status Indicators #41

Closed
Cornelius-Figgle opened this issue May 27, 2023 · 6 comments
Closed
Labels
C-feature-request Category: A feature request

Comments

@Cornelius-Figgle
Copy link

@mortie#25

Basically, are the ideas mentioned in the original issue planned to be implemented? I would love to be able to check the battery status without unlocking the screen every time

@mekb-turtle
Copy link

alternative idea: let specific windows (e.g waybar) be visible past swaylock, I'm not sure if that's possible though

@sidharthmrao
Copy link

I just added a PR for a battery percentage indicator, what should I do next? Or do I just wait until someone reviews it? First open source PR so I'm unsure.

@Cornelius-Figgle
Copy link
Author

I will take a look at that!

I think a more generic way to create a custom indicator would be beneficial, ie a text element that displays the output of a command somehow.

@sidharthmrao
Copy link

That sounds good, I should be able to add that in pretty easily with the way I set up the battery indicator right now.

@sidharthmrao
Copy link

Updated it to work with any script and write the output text to the screen.

@Cornelius-Figgle
Copy link
Author

awesome, I will take a look at it (at some point 😂).

Since I raised the original issue I no longer use Linux on my laptop (but I do my desktop) so the battery indicator isn't useful for me anymore, but I imagine it will for countless others, and generic script output will definitely be useful

PR #65 (linked here for completeness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request
Projects
None yet
Development

No branches or pull requests

4 participants